iosevka: 1.11.4 -> 1.12.1 #24527
Merged
iosevka: 1.11.4 -> 1.12.1 #24527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zimbatm, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ericsagnes, @cstrahan and @winniequinn to be potential reviewers. |
ndowens
reviewed
Apr 1, 2017
|
|
||
| buildInputs = [ unzip ]; | ||
|
|
||
| src = fetchurl { | ||
| url = "https://github.com/be5invis/Iosevka/releases/download/v${version}/01-iosevka-${version}.zip"; |
There was a problem hiding this comment.
Try to use fetchFromGitHub if you can; also wouldn't need unzip as a dep
There was a problem hiding this comment.
fetchFromGitHub doesn't download pre-built assets
|
Everything here looks good to me! 1.12.1 is already out though so it would be worth updating the version before merging. |
use the pack that containes more variants of the font
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I switched the source to fetch the more complete font pack.
Motivation for this change
Hackernews-driven package update.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)