Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

idea: numerous fixes and improvements #24526

Merged
merged 10 commits into from Apr 11, 2017
Merged

idea: numerous fixes and improvements #24526

merged 10 commits into from Apr 11, 2017

Conversation

miltador
Copy link

@miltador miltador commented Apr 1, 2017

Motivation for this change

Improve JetBrains IDE packages.

  • Fix JetBrains IDEs are put under wrong scope #24453: JetBrains IDEs are put under wrong scope
  • sort packages alphabetically in default.nix to reduce a mess
  • update CLion, Datagrip, RubyMine to latest versions
  • add Rider and Gogland IDEs, this makes JetBrains IDE set for NixOS complete
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@miltador, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edwtjo, @chris-martin and @globin to be potential reviewers.

@Ma27
Copy link
Member

Ma27 commented Apr 1, 2017

I really like the changes. However I think that you should document the breaking change done by renaming idea to jetbrains in all-packages.nix

@miltador
Copy link
Author

miltador commented Apr 1, 2017

@Ma27, good catch! Added a note to release notes.

@chris-martin
Copy link
Contributor

I like the rename. Please add an deprecated alias to aliases.nix.

@miltador
Copy link
Author

miltador commented Apr 3, 2017

@chris-martin, done.

matthiasbeyer
matthiasbeyer approved these changes Apr 4, 2017
View reviewed changes
Copy link
Contributor

@matthiasbeyer matthiasbeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like these changes, so I approve (did not test-build, though).

@Mic92 Mic92 merged commit c84dd4f into NixOS:master Apr 11, 2017
@kvtb kvtb mentioned this pull request Oct 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiasbeyer matthiasbeyer matthiasbeyer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@miltador @mention-bot @Ma27 @chris-martin @matthiasbeyer @Mic92