[WIP] sks-module: init #24516
Closed
[WIP] sks-module: init #24516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@primeos, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @joachifm and @offlinehacker to be potential reviewers. |
primeos
added a commit
that referenced
this pull request
Sep 8, 2018
TODO: Merge this module with #24516
|
@primeos any motivation to continue with this PR? |
|
@aanderse Sorry for the delay :o And thanks for tackling stale PRs :) Unfortunately this PR was missed when #27515 was created/merged, and I forgot to close this PR. I'll try to merge the additional functionality/features of this PR gradually into the existing module, but it might take me some time (I already started with some minor improvements and fixes in #46361 and #46370). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I wrote this a long time ago but never actually finished it... 馃槼 It should basically work but some stuff is still missing and it isn't really polished yet and I didn't spend that much time actually testing it. Also there are some difficult design decisions, especially regarding the initial building of the database (except for a "standalone" server (e.g. for a KSP) this can take a long time and one needs to download a huge keydump).
I hope I can actually finish it within the next few months. I thought it might be worth making a PR for the following reasons:
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)