Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

utop: fix on OCaml 4.04 #24524

Merged
merged 1 commit into from Apr 1, 2017
Merged

utop: fix on OCaml 4.04 #24524

merged 1 commit into from Apr 1, 2017

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Apr 1, 2017

Motivation for this change

See #24496. utop does not run properly on linux.

This PR makes two things to address the issue.

  1. the binaries are not stripped, as this confuses ocamlrun.
  2. the wrapper — which is needed to set a couple of environment variables — is customized to directly run ocamlrun.
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@vbgl
utop: fix on OCaml 4.04
033c5de 
Don’t strip the binary
The wrapper directly calls ocamlrun
@mention-bot
Copy link

@vbgl, thanks for your PR! By analyzing the history of the files in this pull request, we identified @FlorentBecker, @samuelrivas and @nbp to be potential reviewers.

@vbgl vbgl mentioned this pull request Apr 1, 2017
Closed
@romildo
Copy link
Contributor

romildo commented Apr 1, 2017

With this patch utop works fine for me. Thanks.

@NeQuissimus NeQuissimus merged commit ed5d80d into NixOS:master Apr 1, 2017
@vbgl vbgl mentioned this pull request May 5, 2017
Closed
@vbgl vbgl deleted the utop_404 branch September 4, 2017 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vbgl @mention-bot @romildo @NeQuissimus