Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode: 1.10.2 -> 1.11.1 #24695

Merged
merged 3 commits into from Apr 7, 2017
Merged

vscode: 1.10.2 -> 1.11.1 #24695

merged 3 commits into from Apr 7, 2017

Conversation

benley
Copy link
Member

@benley benley commented Apr 7, 2017

  • Tested using sandboxing
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@benley, thanks for your PR! By analyzing the history of the files in this pull request, we identified @winniequinn, @uralbash and @jansuchomel to be potential reviewers.

@benley
Copy link
Member Author

benley commented Apr 7, 2017

cc @gebner

This ought to be way easier to maintain! Now just the version number
and sha256 hashes need to be updated for an update, and there are no
more manual cmdline steps to get version hashes and timestamps.

Related to NixOS#22465
Otherwise vscode complains about it.
@gebner gebner merged commit 78adf18 into NixOS:master Apr 7, 2017
@benley benley deleted the vscode-1.11.1 branch April 13, 2017 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants