Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ffmpeg-full: replace SDL support with SDL2 support #24698

Merged
merged 1 commit into from Apr 8, 2017

Conversation

MP2E
Copy link

@MP2E MP2E commented Apr 7, 2017

ffmpeg 3.2 dropped support for SDL1 completely, so migrate to SDL2

Partially addresses issue #24658
(does not fix this issue with the regular ffmpeg package)

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

ffmpeg 3.2 dropped support for SDL1 completely, so migrate to SDL2
@mention-bot
Copy link

@MP2E, thanks for your PR! By analyzing the history of the files in this pull request, we identified @codyopel, @wkennington and @acowley to be potential reviewers.

@MP2E MP2E mentioned this pull request Apr 7, 2017
@aristidb aristidb merged commit 43626b6 into NixOS:master Apr 8, 2017
@MP2E MP2E deleted the ffmpeg_sdl2 branch April 8, 2017 18:56
vcunat pushed a commit that referenced this pull request Apr 14, 2017
ffmpeg-full: replace SDL support with SDL2 support
(cherry picked from commit 43626b6)
@vcunat
Copy link
Member

vcunat commented Apr 14, 2017

Picked to 17.03, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants