Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE beta] Add since tags to deprecations. #15064

Closed
wants to merge 1 commit into from

Conversation

Serabe
Copy link
Member

@Serabe Serabe commented Mar 24, 2017

Tags added:

  • ember-application.app-initializer-initialize-arguments
  • ember-application.app-instance-container
  • ember-application.app-instance-registry
  • ember-application.injected-container
  • ember-application.registry-resolver-as-function
  • ember-application.validate-type
  • ember-degug.deprecate-id-missing
  • ember-degug.deprecate-options-missing
  • ember-degug.deprecate-until-missing
  • ember-degug.warn-id-missing
  • ember-degug.warn-options-missing
  • ember-htmlbars.ember-handlebars-safestring (selecting 2.8 though included in 2.6 betas but reverted before final release)
  • ember-htmlbars.make-bound-helper
  • ember-metal.binding
  • ember-metal.ember-backburner
  • ember-metal.ember-k
  • ember-metal.immediate-observer
  • ember-metal.observer-argument-order
  • ember-metal.required
  • ember-routing-views.controller-wrapped-param
  • ember-routing.router-resource
  • ember-routing.top-level-render-helper
  • ember-runtime.action-handler-_actions
  • ember-runtime.controller-proxy
  • ember-runtime.enumerable-contains
  • ember-runtime.freezable-init
  • ember-runtime.frozen-copy
  • ember-runtime.will-merge-mixin
  • ember-string-utils.fmt
  • ember-template-compiler.deprecate-render
  • ember-template-compiler.transform-input-on-to-onEvent.dynamic-value
  • ember-template-compiler.transform-input-on-to-onEvent.no-action
  • ember-template-compiler.transform-input-on-to-onEvent.normalized-on
  • ember-template-compiler.transform-old-binding-syntax
  • ember-testing.test-waiters
  • ember-views.component.defaultLayout
  • ember-views.did-init-attrs
  • ember-views.lifecycle-hook-arguments
  • ember-views.render-double-modify
  • ember-views.render-to-element

Deprecations not longer found in code:

  • container-lookup-factory

Methodology

Started going through the deprecation list in the CHANGELOG. Those are already covered. Then I started going through the rest of the list bisecting the repo using the v2.x.0 tags. I use the tag when the deprecation was first found.

Fixes #15062

@Serabe
Copy link
Member Author

Serabe commented Mar 24, 2017

I need to take a break to do attend some personal matters but will continue later on this.

@Serabe Serabe force-pushed the feature/add-some-since-tags branch from 01e2d35 to 888956d Compare March 24, 2017 14:00
Tags added:

* ember-application.app-initializer-initialize-arguments
* ember-application.app-instance-container
* ember-application.app-instance-registry
* ember-application.injected-container
* ember-application.registry-resolver-as-function
* ember-application.validate-type
* ember-degug.deprecate-id-missing
* ember-degug.deprecate-options-missing
* ember-degug.deprecate-until-missing
* ember-degug.warn-id-missing
* ember-degug.warn-options-missing
* ember-htmlbars.ember-handlebars-safestring (selecting 2.8 though included in 2.6 betas but reverted before final release)
* ember-htmlbars.make-bound-helper
* ember-metal.binding
* ember-metal.ember-backburner
* ember-metal.ember-k
* ember-metal.immediate-observer
* ember-metal.observer-argument-order
* ember-metal.required
* ember-routing-views.controller-wrapped-param
* ember-routing.router-resource
* ember-routing.top-level-render-helper
* ember-runtime.action-handler-_actions
* ember-runtime.controller-proxy
* ember-runtime.enumerable-contains
* ember-runtime.freezable-init
* ember-runtime.frozen-copy
* ember-runtime.will-merge-mixin
* ember-string-utils.fmt
* ember-template-compiler.deprecate-render
* ember-template-compiler.transform-input-on-to-onEvent.dynamic-value
* ember-template-compiler.transform-input-on-to-onEvent.no-action
* ember-template-compiler.transform-input-on-to-onEvent.normalized-on
* ember-template-compiler.transform-old-binding-syntax
* ember-testing.test-waiters
* ember-views.component.defaultLayout
* ember-views.did-init-attrs
* ember-views.lifecycle-hook-arguments
* ember-views.render-double-modify
* ember-views.render-to-element

Deprecations not longer found in code:

* container-lookup-factory

Some more tags:
@homu
Copy link
Contributor

homu commented Mar 26, 2017

☔ The latest upstream changes (presumably #15043) made this pull request unmergeable. Please resolve the merge conflicts.

@rwjblue
Copy link
Member

rwjblue commented Apr 3, 2017

The data gathered here has been incorporated into #15066, thank you!

@rwjblue rwjblue closed this Apr 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Project Svelte] Deprecation Introduction Hitlist
3 participants