Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow running acceptance tests without jQuery #15063

Closed
cibernox opened this issue Mar 24, 2017 · 12 comments
Closed

Allow running acceptance tests without jQuery #15063

cibernox opened this issue Mar 24, 2017 · 12 comments
Labels
Good for New Contributors Has PR

Comments

@cibernox
Copy link
Contributor

cibernox commented Mar 24, 2017 •
edited

As part of the work of the work performed in https://github.com/cibernox/ember-native-dom-helpers to provide consistent jquery-free test helpers that work both in integration and acceptance I've found that acceptance tests don't work without jQuery.

The reason for that is (at least) this file: https://github.com/emberjs/ember.js/blob/master/packages/ember-testing/lib/setup_for_testing.js#L38-L44

The task is to feature-detect jquery and skip those lines if not present.

For those interested, you can see how to remove jquery from an ember-app in this commit: cibernox/ember-native-dom-helpers@5ebeeb6
@cibernox cibernox changed the title Allow running tests without jQuery Allow running acceptance tests without jQuery Mar 24, 2017
@rwjblue rwjblue mentioned this issue Mar 24, 2017
Merged
@rwjblue
Copy link
Member

rwjblue commented Mar 24, 2017

I submitted #15065 for the specific thing mentioned, but I suspect there are more things that we need to do after that lands.

@pixelhandler
Copy link
Contributor

@cibernox @rwjblue should this be in a RFC issue (not PR) instead of here? @Serabe are will still encouraging feature types of issues to go through the RFCs repo?

@rwjblue
Copy link
Member

rwjblue commented Mar 24, 2017

@pixelhandler - This isn't really adding a new feature at all. Simply removing an error condition in one usage scenario. We are definitely not saying that folks should drop jQuery (only they want to), and we are not modifying the default blueprint.

@mixonic
Copy link
Sponsor Member

mixonic commented Mar 26, 2017

Are there more items to cover here @cibernox, or can this issue be closed?

@rwjblue
Copy link
Member

rwjblue commented Mar 26, 2017

@mixonic - The first known issue was addressed but we need to test again against canary builds. I haven't had a chance yet TBH.

@cibernox
Copy link
Contributor Author

cibernox commented Mar 26, 2017 •
edited

I just tried and no, there is still more work to do. I will be able to help with this after emberconf.

@samjjc
Copy link

samjjc commented Mar 28, 2017

I would like to work on this. It might take a little time, though. I am new here. any advice to help me get started is welcome

@Serabe
Copy link
Member

Serabe commented Jul 13, 2017

@cibernox ping!

@cibernox
Copy link
Contributor Author

cibernox commented Jul 13, 2017 via email

@Serabe
Copy link
Member

Serabe commented Jul 13, 2017

I know! It was more a simulación en diferido de ping.

@pixelhandler
Copy link
Contributor

@cibernox does this issue need to stay open?

@cibernox
Copy link
Contributor Author

cibernox commented Nov 3, 2017

Actually, no. Acceptance tests are fine, provided people don't use the built-in global helper (find, fillIn) but the ones in https://github.com/cibernox/ember-native-dom-helpers

I'll close it.

@cibernox cibernox closed this as completed Nov 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good for New Contributors Has PR
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@mixonic @rwjblue @pixelhandler @Serabe @cibernox @samjjc