eccodes: init at 2.2.0 #24278
Merged
eccodes: init at 2.2.0 #24278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndowens
reviewed
Mar 24, 2017
| openjpeg | ||
| gfortran | ||
| ]; | ||
| propagatedBuildInputs = stdenv.lib.optionals enablePython [ |
There was a problem hiding this comment.
You can remove stdenv.lib here and in meta and put with stdenv.lib; at top
knedlsepp
force-pushed
the
add_eccodes
branch
2 times, most recently
from
c38d565
to
680142c
Compare
ndowens
reviewed
Mar 24, 2017
| meta = { | ||
| homepage = "https://software.ecmwf.int/wiki/display/ECC/"; | ||
| license = licenses.asl20; | ||
| maintainers = with maintainers; [ knedlsepp ]; |
There was a problem hiding this comment.
Since there is only one maintainer, should be:
maintainers = [ maintainers.knedlseep ];
There was a problem hiding this comment.
Is this in any style guide? I've actually seen this form quite often here.
There was a problem hiding this comment.
The way you have it is generally used for multiple people. My suggestion is how I do it when I update packages and also seen this recommendation in other reviews
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Adding the library eccodes, which provides I/O routines for accessing grib/bufr/GTS header files.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)