ghcjsHEAD: upgrade ghcjs-boot packages #24279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@basvandijk, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Profpatsch and @TravisWhitaker to be potential reviewers. |
|
Please hold with merging this. I discovered an issue while running our app. |
basvandijk
force-pushed
the
ghcjsHEAD-upgrade-to-latest-LTS
branch
2 times, most recently
from
bf9d540
to
c01954c
Compare
Move them closer to the latest LTS Haskell.
basvandijk
force-pushed
the
ghcjsHEAD-upgrade-to-latest-LTS
branch
from
c01954c
to
1c656d2
Compare
|
The issue has been resolved and it now works correctly. |
peti
added a commit
that referenced
this pull request
Mar 24, 2017
ghcjsHEAD: upgrade ghcjs-boot packages(cherry picked from commit 0114668)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@TravisWhitaker @peti at LumiGuide we have some trouble with incompatible
aesonversions between GHC and GHCJS. In ghcjs/ghcjs-boot#41 I move theghcjs-bootpackages closer to the latest LTS.I tested it by building and running a big GHCJS app.
What do you think about this? Is it OK to merge or do you want to wait until the upstream PR is merged? (In defence of merging: I emailed Luite a week ago about upgrading
aesonbut he didn't respond. Probably because he's traveling through China according to Facebook.)If you want to merge it it would be great if this can also be cherry-picked on
release-17.03.