Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quassel-webserver: 2.1.1 -> 2.2.8 #24271

Closed
wants to merge 1 commit into from
Closed

quassel-webserver: 2.1.1 -> 2.2.8 #24271

wants to merge 1 commit into from

Conversation

uwap
Copy link
Contributor

@uwap uwap commented Mar 24, 2017

Motivation for this change
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@uwap, thanks for your PR! By analyzing the history of the files in this pull request, we identified @aszlig and @joachifm to be potential reviewers.

@uwap
Copy link
Contributor Author

uwap commented Mar 26, 2017

@Mic92 Please Review :)

@joachifm
Copy link
Contributor

Why add 3000+ lines for this?

@uwap
Copy link
Contributor Author

uwap commented Mar 26, 2017 via email •
edited

@uwap
Copy link
Contributor Author

uwap commented Apr 22, 2017

@joachifm @Mic92 ping?

@joachifm
Copy link
Contributor

Too much for one package for my tastes, sorry.

@joachifm
Copy link
Contributor

joachifm commented Apr 22, 2017 •
edited

Maybe some of it could be moved to the global nodejs package set, to reduce the footprint.

@uwap
Copy link
Contributor Author

uwap commented Apr 22, 2017 via email

@c0bw3b c0bw3b mentioned this pull request Nov 14, 2017
Merged
8 tasks
@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 15, 2017

Closing this : quassel-wbeserver has been updated to 2.2.8 in #31655

@c0bw3b c0bw3b closed this Nov 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: merge conflict
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@uwap @mention-bot @joachifm @c0bw3b @pSub