Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plugins to 2.0 API #97

Merged
merged 1 commit into from Apr 15, 2017
Merged

Update plugins to 2.0 API #97

merged 1 commit into from Apr 15, 2017

Conversation

samj1912
Copy link
Collaborator

No description provided.

@samj1912 samj1912 changed the base branch from master to 2.0 April 13, 2017 12:46
@samj1912 samj1912 changed the base branch from 2.0 to master April 13, 2017 12:48
@samj1912 samj1912 changed the base branch from master to 2.0 April 13, 2017 12:48
@samj1912 samj1912 requested a review from zas April 13, 2017 12:51
@phw
Copy link
Member

phw commented Apr 13, 2017

Why so many complete removals? Shouldn't we aim to update those, too?

@samj1912
Copy link
Collaborator Author

I am going to eventually port all of them. Currently these are the ones ported. I want them to be added so people can start using plugins ASAP.

The rest will be ported over this week. You are welcome to help :)

@mwiencek
Copy link
Member

Shouldn't we just be able to make PLUGIN_API_VERSIONS an empty list instead of removing the files?

@samj1912
Copy link
Collaborator Author

@mwiencek the generation script will still pick it up and it will be displayed in Picard?

@mwiencek
Copy link
Member

Is there a reason Picard displays incompatible plugins, or the generation script needs to pick them up? That was one of the problems I mentioned a while ago on IRC. Ideally I just think we shouldn't create these huge commits if we don't need to, since they inflate the size of the repo and make git blame harder to use.

@samj1912
Copy link
Collaborator Author

Fair point, Ill update the generation script to reject the plugins not within compatible apis.

@samj1912
Copy link
Collaborator Author

Updated this PR. Not deleting any files now, instead changed the generation script @ PW.

@zas zas merged commit c7a4968 into metabrainz:2.0 Apr 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants