Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pp: fixed to return value like 'p' #4283

Merged
merged 1 commit into from
Apr 18, 2017
Merged

pp: fixed to return value like 'p' #4283

merged 1 commit into from
Apr 18, 2017
+15 −7

Conversation

makenowjust
Copy link
Contributor

@makenowjust makenowjust commented Apr 13, 2017 •
edited
Loading

Current implementation of pp returns nil always, but p returns printed value. It fixes to return printed value of 'pp' like p. I think its usability equals to p result value's.

@makenowjust
pp: fixed to return value like 'p'
ecd5266 
Current implementation of pp returns `nil` always, but `p` returns printed
value. It fixes to return printed value of 'pp'.
@asterite
Copy link
Member

Nice! That way one can wrap an expression with p and have it return the same value, super useful for debugging purposes. Thank you!

@asterite asterite merged commit 8ad21bc into crystal-lang:master Apr 18, 2017
@asterite asterite added this to the Next milestone Apr 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
kind:feature topic:stdlib
Projects
None yet
Milestone
0.22.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@makenowjust @asterite