Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetbrains Idea-Ultimate 2016.3.4 -> 2017.1 #24870

Merged
merged 1 commit into from Apr 13, 2017
Merged

Jetbrains Idea-Ultimate 2016.3.4 -> 2017.1 #24870

merged 1 commit into from Apr 13, 2017

Conversation

rydnr
Copy link
Contributor

@rydnr rydnr commented Apr 13, 2017

Motivation for this change

Support for latest Idea-Ultimate (2017.1).

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Apr 13, 2017

What is our policy for backports of IDEs major revisions? Same thing as Atom? #24863

@rydnr
Copy link
Contributor Author

rydnr commented Apr 13, 2017

I should've requested the pull against master, not the release-17.03 tag.

@rydnr rydnr closed this Apr 13, 2017
@NeQuissimus
Copy link
Member

@Mic92 We generally bring those into stable when an old version stops working properly (to some degree). With Atom, for example, you can't install certain plugins anymore if you are too far behind...

@Mic92
Copy link
Member

Mic92 commented Apr 13, 2017

@rydnr we already have it in master. But it is probably also ok to push it to master.

@Mic92 Mic92 reopened this Apr 13, 2017
@NeQuissimus
Copy link
Member

@Mic92 You mean 17.03? We can just cherry-pick the commit rather than using this PR. Probably easier if we ever need to merge larger chunks from one branch to the other...

@Mic92
Copy link
Member

Mic92 commented Apr 13, 2017

@NeQuissimus this is probably not possible, because we have recently moved idea to jetbrains.

@NeQuissimus
Copy link
Member

@Mic92 Oh okay... Did not know that... The merge is probably fine then

@Mic92 Mic92 merged commit 587d1a3 into NixOS:release-17.03 Apr 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants