Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

p: not display if no object is given #4285

Merged
merged 1 commit into from Apr 18, 2017
Merged

p: not display if no object is given #4285

merged 1 commit into from Apr 18, 2017

Conversation

makenowjust
Copy link
Contributor

Currently p (invoke p with no argument) shows {} because def p(**objects) handles it. But in this case it should not display anything and return nil.

@makenowjust
p: not display if no object is given
804a57d 
Currently `p` (invoke `p` with no argument) shows `{}` because `def p(**objects)` handles it. But in this case it should not display anything and return `nil`.
@asterite
Copy link
Member

Nice catch, thank you!

@asterite asterite merged commit a5ac971 into crystal-lang:master Apr 18, 2017
@asterite asterite added this to the Next milestone Apr 18, 2017
@makenowjust makenowjust deleted the fix/p/empty-display branch July 7, 2017 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
kind:feature topic:stdlib
Projects
None yet
Milestone
0.22.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@makenowjust @asterite