Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add libgme #24872

Merged
merged 2 commits into from May 1, 2017
Merged

Add libgme #24872

merged 2 commits into from May 1, 2017

Conversation

lheckemann
Copy link
Member

Motivation for this change

Adds support to gstreamer for a number of additional music formats.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@lheckemann, thanks for your PR! By analyzing the history of the files in this pull request, we identified @spwhitt, @lethalman and @fpletz to be potential reviewers.

Copy link
Member

@matthewbauer matthewbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add meta to libgme?

@lheckemann
Copy link
Member Author

Whoops, forgot about that. Thanks.

@7c6f434c 7c6f434c merged commit 3a548b8 into NixOS:master May 1, 2017
@lheckemann lheckemann deleted the libgme branch May 1, 2017 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants