Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rstudio: 0.98.110 -> 1.1.135 #24615

Closed
wants to merge 1 commit into from
Closed

rstudio: 0.98.110 -> 1.1.135 #24615

wants to merge 1 commit into from

Conversation

lukego
Copy link
Contributor

@lukego lukego commented Apr 4, 2017

This is a work-in-progress update of Rstudio from 0.98.110 to 1.1.135.

The problem I am stuck on now is that RStudio wants to include a specific version of pandoc in its own directory as a dependency. Help wanted!

Motivation for this change

Catch up with the latest RStudio release and especially with the major 1.0 release that was made in November. For me as a user I really want at least RStudio 1.0 to happily migrate my RStudio usage from MacOSX to NixOS.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@lukego
rstudio: 0.98.110 -> 1.1.135 (WORK IN PROGRESS)
1f6d364 
Major upgrade of Rstudio.

Currently broken due to unmet dependency of Rstudio wanting to install a
pandoc binary in a special location.
@mention-bot
Copy link

@lukego, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Hodapp87, @ehmry and @lverns to be potential reviewers.

@aristidb aristidb changed the title rstudio: 0.98.110 -> 1.1.135 (WORK IN PROGRESS) rstudio: 0.98.110 -> 1.1.135 Apr 8, 2017
@lverns
Copy link
Contributor

lverns commented Apr 9, 2017

@lukego feel free to cherrypick lverns@25fdd35. It solves the pandoc problem, but then fails at getting rmarkdown (and presumably rsconnect will be the next issue).

I would take a look at dependencies/common/install-packages to figure out how to get rmarkdown in a place where the Rstudio build process can find it.

@lverns
Copy link
Contributor

lverns commented Apr 30, 2017

Do we want to close this since #25338 got merged? I realize that the other PR only brings RStudio up to 1.1.126 instead of 1.1.135, but if that is a problem, it probably still makes sense to ditch this and branch off of master again.

@changlinli
Copy link
Contributor

It actually brings it up to 1.1.216 not 1.1.126 so actually more recent. Although in between me making the commits locally and the pull request being accepted they just released version 1.1.217 so this could be that instead :)

@changlinli
Copy link
Contributor

Also my apologies for not noticing that there was ongoing effort in this space, otherwise I would've coordinated with you guys rather than just stepping over.

@lukego
Copy link
Contributor Author

lukego commented Apr 30, 2017

Fantastic, thanks @changlinli for doing that upgrade! Happy to close this PR and looking forward to trying your update :)

@lukego lukego closed this Apr 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: work-in-progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lukego @mention-bot @lverns @changlinli @aristidb