Fix: OpenSSL 1.1.0 changed context options #4234
Merged
+74
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ysbaddaden
commented
Apr 4, 2017
| (context.options & OpenSSL::SSL::Options::NO_SSLV3).should eq(OpenSSL::SSL::Options::NO_SSLV3) | ||
| (context.options & OpenSSL::SSL::Options::NO_SESSION_RESUMPTION_ON_RENEGOTIATION).should eq(OpenSSL::SSL::Options::NO_SESSION_RESUMPTION_ON_RENEGOTIATION) | ||
| (context.options & OpenSSL::SSL::Options::SINGLE_ECDH_USE).should eq(OpenSSL::SSL::Options::SINGLE_ECDH_USE) | ||
| (context.options & OpenSSL::SSL::Options::SINGLE_DH_USE).should eq(OpenSSL::SSL::Options::SINGLE_DH_USE) |
There was a problem hiding this comment.
We can't assume the options are a fixed set. OpenSSL may have set some by default, already.
ysbaddaden
force-pushed
the
std-fix-openssl-110
branch
from
d29c0f5 to
d8bd1f8
Compare
SSLv2 support was removed, some context options were disabled, and the following symbols were previously macros: - SSL_CTX_get_options - SSL_CTX_set_options - SSL_CTX_clear_options
ysbaddaden
force-pushed
the
std-fix-openssl-110
branch
from
d8bd1f8 to
ecd7c91
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SSLv2 support was removed, some context options were disabled, and the following symbols were previously macros:
SSL_CTX_get_optionsSSL_CTX_set_optionsSSL_CTX_clear_options