Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

baobab: fix missing dconf module #24617

Merged
merged 1 commit into from Apr 4, 2017
Merged

baobab: fix missing dconf module #24617

merged 1 commit into from Apr 4, 2017

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Apr 4, 2017 •
edited

fix Using the 'memory' GSettings backend

@abbradar this seems to be a common missed dependency in gtk apps. Can we make gsettings_desktop_schemas also providing dconf by default?

Related to #24602

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@abbradar
Copy link
Member

abbradar commented Apr 4, 2017 •
edited

dconf is not needed when wrapGAppsHook is used: https://github.com/NixOS/nixpkgs/blob/master/pkgs/top-level/all-packages.nix#L328

BTW, gsettings_desktop_schemas are not usually needed -- they contain only GNOME3-specific schemas which most applications do not need. Most of the time only schemas from gtk3 are needed so the problem is that application is not wrapped with wrapGAppsHook.

EDIT: we have a lot of unneeded gsettings_desktop_schemas usage in nixpkgs because of misleading error message "No GSettings schemas found".

@Mic92 Mic92 merged commit 15c2af4 into NixOS:master Apr 4, 2017
@Mic92 Mic92 deleted the baobab branch April 4, 2017 14:14
@Mic92
Copy link
Member Author

Mic92 commented Apr 4, 2017

ok. now it works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mic92 @abbradar