Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing post scanner plugin order #2720

Merged
merged 3 commits into from Apr 14, 2017
Merged

Fixing post scanner plugin order #2720

merged 3 commits into from Apr 14, 2017

Conversation

felixfontein
Copy link
Contributor

Fixes #2542.

Kwpolska
Kwpolska reviewed Apr 14, 2017
View reviewed changes
nikola/nikola.py Outdated
@@ -2098,7 +2098,7 @@ def scan_posts(self, really=False, ignore_quit=False, quiet=False):
self.timeline = []
self.pages = []

for p in self.plugin_manager.getPluginsOfCategory('PostScanner'):
for p in sorted(self.plugin_manager.getPluginsOfCategory('PostScanner'), key=lambda p: p.name):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

key=operator.attrgetter('name')

Kwpolska
Kwpolska approved these changes Apr 14, 2017
View reviewed changes
Copy link
Member

@Kwpolska Kwpolska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kwpolska Kwpolska merged commit 6356485 into master Apr 14, 2017
@Kwpolska Kwpolska deleted the fixing-2542 branch April 14, 2017 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kwpolska Kwpolska Kwpolska approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@felixfontein @Kwpolska