add disk type storage to libvirt #24822
Conversation
|
@techhazard, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fpletz, @rickynils and @volth to be potential reviewers. |
|
I was not yet able to test the finished build. How would I make my current version of |
|
You can build your system from a nixpkgs working tree: |
| @@ -4,7 +4,7 @@ | |||
| , iproute, iptables, readline, lvm2, utillinux, systemd, libpciaccess, gettext | |||
| , libtasn1, ebtables, libgcrypt, yajl, pmutils, libcap_ng, libapparmor | |||
| , dnsmasq, libnl, libpcap, libxslt, xhtml1, numad, numactl, perlPackages | |||
| , curl, libiconv, gmp, xen, zfs | |||
| , curl, libiconv, gmp, xen, zfs, parted | |||
There was a problem hiding this comment.
You forgot to add parted to buildInputs.
There was a problem hiding this comment.
whoops, my bad 😅
|
I tried building on OSX but that requires setting @bjornfor I'll probably test it tonight |
|
I tested it last night, and it seems to work. I did have to reformat the pool manually in |
|
@volth should I add that to this PR? |
|
Awesome! |
Motivation for this change
libvirtis currently compiled without support for thedisktype storage resulting in an error when attempting to add one (the option is still available invirt-manager).This adds a flag to the compile steps (i.e. to
./configure) to enable thediskstorage type. Since this requiresparted, I've also added that. (try running this withoutpartedin the arguments list, you'll see).Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)