plasma-nm: Fix cipher discovery by setting path to openvpn #24816
Conversation
This thing takes a long time to build.
| (substituteAll { | ||
| src = ./0002-openvpn-binary-path.patch; | ||
| inherit openvpn; | ||
| }) |
There was a problem hiding this comment.
I would prefer makeWrapper to extend PATH if possible, so we do not have to maintain this patch in future updates.
There was a problem hiding this comment.
That does sound sensible; I only went with a patch following the existing example. I'll switch to a wrapper.
There was a problem hiding this comment.
Adding openvpn to propagatedBuildInputs might also work
There was a problem hiding this comment.
I'm not sure that makeWrapper will do the job here. plasma-nm provides several plugins (plasmoids) and there is no guarantee which executable will load each.
Adding it to propagatedBuildInputs will not work.
I would prefer the path be patched into the source code as with other executables.
There was a problem hiding this comment.
OK - which one is it going to be? The only approach that I know will reliably work is patching the source. If updating the patch becomes irritating over time, maybe we can find a way to do it with sed or something instead of a patch?
There was a problem hiding this comment.
I'm merging it as is.
The irritation of updating the patches is a red herring; I've been maintaining these packages for years and I can count the number of patches I have updated on one hand.
Motivation for this change
As seen in #24808 , it's not possible to configure the cipher field without this patch. I also toggled enableParallelBuild because this package takes surprisingly long to compile.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)