pypi2nix: 1.6.0 -> 1.8.0 #24823
Closed
pypi2nix: 1.6.0 -> 1.8.0 #24823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also updated its dependencencies: - pythonPackage.pycodestyle: 2.0.0 -> 2.3.1 - pythonPackage.mccabe: 0.5.3 -> 0.6.1 - pythonPackage.pyflakes: 1.3.0 -> 1.5.0
|
@garbas, thanks for your PR! By analyzing the history of the files in this pull request, we identified @taku0, @mythmon, @wkennington and @FRidh to be potential reviewers. |
|
Should the |
|
@taku0 right. well if the Travis will succeed I'm going to push it to master anyway. |
|
ah travis reaches 10k limit ... I will build this on my hydra and if successful I will push to master |
|
mccabe and flake8 are typically tricky to upgrade. Often packages require an older version which is why we're still stuck on these versions. |
|
@FRidh flake8 fails for me on python35, when running it not when building it |
|
well i'll just push pypi2nix with checkPhase disabled |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
update to flake8 and its deps is also needed
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)