Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gtk3 to clutter buildInputs #24815

Merged
merged 1 commit into from Apr 27, 2017
Merged

Add gtk3 to clutter buildInputs #24815

merged 1 commit into from Apr 27, 2017

Conversation

jonafato
Copy link
Contributor

@jonafato jonafato commented Apr 11, 2017 •
edited

Motivation for this change

gnome3.sushi is broken. With this change, it seems to work again. This is similar to the change made in PR #12996. Fixes #21509.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@jonafato, thanks for your PR! By analyzing the history of the files in this pull request, we identified @urkud, @vcunat and @groxxda to be potential reviewers.

@FRidh
Copy link
Member

FRidh commented Apr 11, 2017

Does it really need to be propagated?

@FRidh FRidh closed this Apr 11, 2017
@FRidh FRidh reopened this Apr 11, 2017
@edolstra
Copy link
Member

This seems strange. clutter builds fine without gtk3, but does need to propagate it? That doesn't seem right...

@edolstra
Copy link
Member

The comment #12106 (comment) suggests that gtk3 is needed only as a buildInput to generate some file. Propagating build inputs is a bad practice that should generally be avoided.

@jonafato jonafato force-pushed the clutter-gtk3 branch 2 times, most recently from 0aece5b to 6968d20 Compare April 11, 2017 22:25
@jonafato jonafato changed the title Add gtk3 to clutter propagatedBuildInputs Add gtk3 to clutter buildInputs Apr 11, 2017
@jonafato
Copy link
Contributor Author

@edolstra The first pass of this was just a copy of the previous PR that mentioned fixing gnome3.sushi; I saw that the package was broken and thought I'd apply the same change.

I've moved the gtk3 to buildInputs, and sushi still works. Does this address your comment? Thanks for the help here; I'm still relatively new to nix, so the feedback is appreciated.

@jonafato
Add gtk3 to clutter buildInputs
fc192c5 
This is similar to the same change made in PR NixOS#12996. Fixes NixOS#21509
(makes `gnome3.sushi` work again).
@jonafato
Copy link
Contributor Author

Anything else that needs to change here? It'd be nice to get sushi working again.

@fpletz fpletz merged commit 878b350 into NixOS:master Apr 27, 2017
@jonafato jonafato deleted the clutter-gtk3 branch April 27, 2017 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jonafato @mention-bot @FRidh @edolstra @fpletz