Skip to content

Commit

Permalink
freetype: disable PCF long family names
Browse files Browse the repository at this point in the history
Backported several patches from upstream. The test suite patch for Fontconfig is
no longer necessary.
  • Loading branch information
ttuegel committed Mar 28, 2017
1 parent 036f4b2 commit 9b04984
Show file tree
Hide file tree
Showing 6 changed files with 643 additions and 24 deletions.
4 changes: 0 additions & 4 deletions pkgs/development/libraries/fontconfig/default.nix
Expand Up @@ -33,10 +33,6 @@ stdenv.mkDerivation rec {
url = "https://cgit.freedesktop.org/fontconfig/patch/?id=1ab5258f7c";
sha256 = "0x2a4qx51j3gqcp1kp4lisdzmhrkw1zw0r851d82ksgjlc0vkbaz";
})

# FreeType 2.7 prefixes PCF font family names with the foundry name.
# The output of fc-list and fc-query change which breaks the tests.
./test-pcf-family-names-freetype-2.7.patch
];
# additionally required for the glibc-2.25 patch; avoid requiring gperf
postPatch = ''
Expand Down

This file was deleted.

9 changes: 7 additions & 2 deletions pkgs/development/libraries/freetype/default.nix
Expand Up @@ -43,8 +43,13 @@ stdenv.mkDerivation {
++ optional (!stdenv.isLinux) gnumake;

patches =
[ ./enable-table-validation.patch ]
++ optional useEncumberedCode ./enable-subpixel-rendering.patch;
[
./pcf-introduce-driver.patch
./pcf-config-long-family-names.patch
./disable-pcf-long-family-names.patch
./enable-table-validation.patch
] ++
optional useEncumberedCode ./enable-subpixel-rendering.patch;

outputs = [ "out" "dev" ];

Expand Down
@@ -0,0 +1,15 @@
diff --git a/include/freetype/config/ftoption.h b/include/freetype/config/ftoption.h
index 5676074..37a0d00 100644
--- a/include/freetype/config/ftoption.h
+++ b/include/freetype/config/ftoption.h
@@ -856,7 +856,7 @@ FT_BEGIN_HEADER
/* If this option is activated, it can be controlled with the */
/* `no-long-family-names' property of the pcf driver module. */
/* */
-#define PCF_CONFIG_OPTION_LONG_FAMILY_NAMES
+/* #define PCF_CONFIG_OPTION_LONG_FAMILY_NAMES */


/*************************************************************************/
--
cgit v1.0-41-gc330

4 comments on commit 9b04984

@copumpkin
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ttuegel argh, I just merged master into staging and somehow the magic merger decided it should remove the .patch file but re-add the reference in the .nix file 😦 just to confirm: I should remove that again, right? I have no idea what any of this stuff is 😄

@copumpkin
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copumpkin
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the error I'm getting in Hydra: http://hydra.nixos.org/jobset/nixpkgs/copumpkin-wip#tabs-errors

@copumpkin
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like staging has also been blocked for the past few days on this: http://hydra.nixos.org/jobset/nixpkgs/staging#tabs-errors

Please sign in to comment.