veracrypt: init at 1.19 #24424
veracrypt: init at 1.19 #24424
Conversation
| cd Vera*/src | ||
| ''; | ||
|
|
||
| buildInputs = [ pkgconfig fuse devicemapper wxGTK30 nasm makeself ]; |
There was a problem hiding this comment.
pkgconfig goes into nativeBuildInputs
| homepage = https://veracrypt.codeplex.com/; | ||
| license = "VeraCrypt License"; | ||
| maintainers = null; # TO DEFINE | ||
| platforms = with stdenv.lib.platforms; linux; |
There was a problem hiding this comment.
Should be platforms = platforms.linux since it is only one platform
dsferruzza
force-pushed
the
add-veracrypt
branch
from
2b1b7df
to
c21b1f2
Compare
|
It seems the first change broke the build: https://travis-ci.org/NixOS/nixpkgs/jobs/216476198#L1575 @ndowens Any idea of why it happened? |
| description = "Free Open-Source filesystem on-the-fly encryption"; | ||
| homepage = https://veracrypt.codeplex.com/; | ||
| license = "VeraCrypt License"; | ||
| maintainers = null; # TO DEFINE |
There was a problem hiding this comment.
Do you want to maintains this package?
There was a problem hiding this comment.
What does it implies exactly?
Updating the package when there is an update upstream?
There was a problem hiding this comment.
It implies that you have some vested interest in the package; I don't think there's an implication of a certain level of commitment, really, but you can expect to be pinged if there's an issue.
There was a problem hiding this comment.
OK I understand!
So I shall add myself in lib/maintainers.nix and update the field in the package, right?
|
The change didn't break it. Travis seems to be broken again. The difference between the buildinputs is that native is is used for building the pkg vs buildinputs is for what the pkg uses for runtime |
|
@ndowens I don't believe that the names perfectly describe the semantics, but thanks for the explanation I'll keep that in mind :) |
| cd Vera*/src | ||
| ''; | ||
|
|
||
| nativeBuildInput = [ pkgconfig ]; |
There was a problem hiding this comment.
Typo: should be nativeBuildInputs
There was a problem hiding this comment.
Oh indeed! I fixed it
|
The travis error is legit. |
dsferruzza
force-pushed
the
add-veracrypt
branch
2 times, most recently
from
b247e31
to
8846f93
Compare
|
Added a few things for you to consider. |
|
Thanks I learned a few tips ^_^ |
- Conditionally add wxGTK30 to inputs to avoid eval'ing it regardless of wxGUI - Patch full path to exe into desktop file - Move some inputs to native - Do not write intermediate tar file on unpack
|
Thank you |
|
Thank you for helping me ^_^ Do you now if/when the package will be available in a release channel? |
|
It's already in the unstable channel, but hasn't been picked to the release branch. |
|
OK! |
|
You can submit a PR against the release branch, containing cherry-picked patches (please use |
Motivation for this change
TrueCrypt has been discontinued for several years.
This PR adds a package for VeraCrypt, a maintained fork of TrueCrypt.
I used
truecryptpackage as a start, and tried to create a nice package; but I'm a beginner so I guess not everything is perfect.I would be happy to have feedback and advices!
I tested this package on NixOS.
I was able to successfully do the following steps:
I let the
maintainersfield empty.I don't know if I should add myself, or @viric (the
truecryptpackage maintainer), or someone else.Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)