CONTRIB: mail.py: check if ooc or puppeting before finding player object during get_all_mail #1289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eldritchsemblance
changed the title
|
Changes seem fine to me, from what I could see. If nothing else the change of the default message was welcome. Checked for Python compliance. |
vincent-lg
approved these changes
Mar 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief overview of PR changes/additions
Checks to see if OOC or Puppeting during get_all_mail
Motivation for adding to Evennia
Trying to use the mail system fails when OOC
Other info (issues closed, discussion etc)
This fixes the test failure and the bug introduced in PR #1262