Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fdr: fix Qt library dependency #25000

Merged
merged 1 commit into from Apr 18, 2017
Merged

fdr: fix Qt library dependency #25000

merged 1 commit into from Apr 18, 2017

Conversation

NickHu
Copy link
Contributor

@NickHu NickHu commented Apr 18, 2017

Motivation for this change

25b3a8a broke FDR, this fixes it.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 merged commit 41b43c0 into NixOS:master Apr 18, 2017
@Mic92
Copy link
Member

Mic92 commented Apr 18, 2017

Thanks!

NickHu referenced this pull request Apr 19, 2017
@ttuegel
fdr: pin to Qt 5.6
25b3a8a
@NickHu NickHu deleted the fdr branch August 22, 2017 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@NickHu @Mic92