MEB-90: Add support for donating in EUR using PayPal #264
Conversation
gentlecat
changed the title
There was a problem hiding this comment.
I also tried to create the tables locally after copying over custom_config.py (leaving default currencies in place) but I get this error:
sqlalchemy.exc.ProgrammingError: (psycopg2.ProgrammingError) syntax error at or near "NULL"
LINE 1: CREATE TYPE payment_currency AS ENUM (NULL)
when running create tables. Do I need to configure anything else?
| return | ||
|
|
||
| # Checking if payment was sent to the right account depending on the currency | ||
| if form['mc_currency'].upper() in account_ids: |
There was a problem hiding this comment.
When money is sent to an account for another currency. If that's too redundant, I can remove the check.
There was a problem hiding this comment.
Ideally we should try and avoid this happening in the first place -- is there reason to think that this might still occur?
There was a problem hiding this comment.
If there is a bug in the frontend.
| @@ -219,7 +219,7 @@ <h1 class="page-title">{{ _('Make a Payment') }}</h1> | |||
|
|
|||
| {# Info about variables can be found at https://developer.paypal.com/docs/classic/paypal-payments-standard/integration-guide/Appx_websitestandard_htmlvariables/ #} | |||
|
|
|||
| $('<input>').attr({type: 'hidden', name: 'business', value: '{{ config.PAYPAL_PRIMARY_EMAIL }}'}).appendTo(form); | |||
| $('<input>').attr({type: 'hidden', name: 'business', value: '{{ config['PAYPAL_ACCOUNT_IDS']['USD'] }}'}).appendTo(form); | |||
There was a problem hiding this comment.
I haven't changed "payments" yet. Just donations.
There was a problem hiding this comment.
Ah, I saw the [WIP] on the title of the PR go away, so I thought it was done...
There was a problem hiding this comment.
I split it into two.
Not necessarily. This should work just fine. I'm currently fixing database creation issues that you pointed out before. |
Since we support not just USD now (also EUR).
No description provided.