git-lfs: 1.3.1 -> 2.0.2 #25004
Closed
git-lfs: 1.3.1 -> 2.0.2 #25004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Apr 18, 2017
| ''; | ||
|
|
||
| maintainers = [ lib.maintainers.twey ]; |
There was a problem hiding this comment.
this should be in a meta section:
meta = {
maintainers = [ lib.maintainers.twey ];
};
It would be also nice to have a homepage attribute as well as license and description their.
Mic92
reviewed
Apr 18, 2017
| go generate ./commands | ||
| popd | ||
| ''; | ||
|
|
||
| postInstall = '' | ||
| rm -v $bin/bin/{man,script} | ||
| rm -v $bin/bin/{man,script,genmakefile} |
There was a problem hiding this comment.
I would actually move $bin/bin/man to share/.
There was a problem hiding this comment.
Are you sure? This is an executable that (as far as I can tell) is responsible for generating the manpages.
There was a problem hiding this comment.
Ok. I though this was a directory.
There was a problem hiding this comment.
A directory would require -r.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)