Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.bleach: declare unix support #24841

Merged
merged 1 commit into from Apr 14, 2017
Merged

pythonPackages.bleach: declare unix support #24841

merged 1 commit into from Apr 14, 2017

Conversation

loskutov
Copy link
Contributor

Motivation for this change

bleach doesn't seem to depend on anything linux-specific, so I declared it to support all unix platforms. At least it makes jupyter-notebook work on darwin.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@loskutov, thanks for your PR! By analyzing the history of the files in this pull request, we identified @FRidh to be a potential reviewer.

FRidh
FRidh requested changes Apr 12, 2017
View reviewed changes
Copy link
Member

@FRidh FRidh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better yet is to remove the attribute entirely as it will default to use the attribute of the interpreter

@loskutov
Copy link
Contributor Author

@FRidh fixed

@FRidh
Copy link
Member

FRidh commented Apr 14, 2017

these commits can all be squashed

@loskutov
Copy link
Contributor Author

loskutov commented Apr 14, 2017 •
edited

@FRidh done

@FRidh FRidh merged commit 46403f5 into NixOS:master Apr 14, 2017
@loskutov loskutov deleted the bleech-unix branch April 14, 2017 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@loskutov @mention-bot @FRidh