CB-230: Migrate license related code off the ORM #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gentlecat
reviewed
Apr 13, 2017
critiquebrainz/db/license.py
Outdated
| Returns: | ||
| Dict containing the following attributes | ||
| { | ||
| "id": (str),, |
There was a problem hiding this comment.
Looks like a typo there.
gentlecat
suggested changes
Apr 13, 2017
There was a problem hiding this comment.
I think code that uses creation can be a part of that change. Check https://github.com/metabrainz/critiquebrainz/blob/master/critiquebrainz/data/fixtures.py.
gentlecat
approved these changes
Apr 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added function
license.createandlicense.deletefor creating and deleting licenses. Made changes in their usages accordingly.