pinentry_mac: use xcbuild #24838

matthewbauer · 2017-04-12T08:10:15Z

Motivation for this change

This switches pinentry_mac over to xcbuild.

Sadly, pinentry_mac does not work out of the box. I've had to make a few changes for it to compile:

Update .xib to newer Xcode
Remove passphrase formatter (see issue "customFormatter" not implemented in xib2nib microsoft/WinObjC#2501)
Update to 10.10 MacOS SDK (we don't support older SDKs like Xcode does)
Disable ARC features (seems to be related to 10.10 SDK)
Removed .pch (see issue prefix.pch not found facebookarchive/xcbuild#244)

This PR adds a couple of new packages too:

plist-cpp
nsplist
xib2nib (based off of WinObjC)

Each of these packages needs some changes to get working from MSVSC to NixPkgs, so I'm going to try to work to get those changes include so we have legitimate versioning.

I'll try to clean this PR up in the coming, but right now it works as is.

Things done

Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- Linux
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

cctools provides install_name_tool

- init package - add into xcbuild/toolchain.nix

This is an attempt to get rid of the issues with sdk not found in xcbuild when building pinentry_mac.

Fixes NixOS#24734

mention-bot · 2017-04-12T08:10:25Z

@matthewbauer, thanks for your PR! By analyzing the history of the files in this pull request, we identified @lovek323, @globin, @pSub and @FRidh to be potential reviewers.

These libraries could be used by other packages so list them in all-packages.nix as well.

This reverts commit 87e6b2c.

copumpkin · 2017-04-12T11:28:27Z

Whoa, you figured out where to get a pure ibtool-equivalent??

matthewbauer · 2017-04-12T12:40:24Z

@copumpkin Microsoft has tool inside of WinObjC called xib2nib. I've moved it to a separate repo and got it running on *nix systems. Then I made a bash wrapper that fakes ibtool options and passes them to xib2nib. That means there are some parts of ibtool that it doesn't actually implement. In addition xib2nib has spotty support for some nib files especially older ones (like in pinentry_mac). So after some modifications pinentry_mac is able to work with it.

copumpkin

Awesome. Anyway, I'm fine with merging this but if you want to do more work to it first, that's also fine.

matthewbauer · 2017-04-12T13:41:11Z

Ok even though it builds correctly, something weird is going on with the .nib file. I'm marking it [wip] for right now.

sadly, xib2nib hasn't been working like i though. I've just precompiled into our modified pinentry_mac. Eventually we can get this fixed but it's not as easy as first thought.

also: - NSPlist - PlistCpp

matthewbauer · 2017-04-13T01:13:02Z

Looks good to me if no one has anything to fix.

Some notes on xib2nib:

it only supports "CocoaTouch" layouts and storyboards not "Cocoa"
we can get it working eventually, but there isn't much documentation on Cocoa layouts
the IBCocoa .nib format seems to be a nskeyedarchive but I don't know how to extract it without a defined struct

copumpkin · 2017-04-13T01:23:11Z

How does it work for pinentry if it only supports cocoatouch?

…

On Apr 12, 2017, at 21:13, Matthew Justin Bauer ***@***.***> wrote: Looks good to me if no one has anything to fix. Some notes on xib2nib: it only supports "CocoaTouch" layouts and storyboards not "Cocoa" we can get it working eventually, but there isn't much documentation on it. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

matthewbauer · 2017-04-13T01:39:31Z

@copumpkin So, I'm cheating now and just compiling them in Xcode and checking them into the pienntry_mac tree. I want to keep xib2nib in here though because eventually it should be useful.

copumpkin · 2017-04-13T01:40:17Z

Oh, I see. That works for now I guess 😄 so the xib2nib tool isn't actually used here?

copumpkin · 2017-04-13T01:41:34Z

Also, is converting xib files to nib files the only thing builds generally need to do? I've done a lot of reverse engineering and we could probably revive https://github.com/davidquesada/ibtool without much effort.

matthewbauer · 2017-04-13T01:47:42Z

I'd say that converting xib to nib is the main thing. Storyboards may also be includes and they're basically just a wrapper around a bunch of .xib's. That part involves linking and compiling but that shouldn't be a big deal.

You're going to have the same problem with ibtool.py though where it just works with CocoaTouch. I've been looking at the format of .nib's and it's not very well documented. They look like they're just binary plists encoded as nskeyedarchive.

copumpkin · 2017-04-13T01:48:52Z

What's the main difference between CocoaTouch and Cocoa for this? Is it just that there's a bigger RE community around iOS?

matthewbauer · 2017-04-13T01:54:20Z

Probably because iOS is more locked down and stuff so you can't use some other layout tools like in gtk or qt. Also Cocoa has a lot more features that need to be included to work while CocoaTouch has relatively less. Even for CocoaTouch I don't think it works with 100% of layouts.

copumpkin · 2017-04-13T01:56:37Z

I just took a peek at the "source" for ibtool and there really isn't that much of it... 😄 and it doesn't seem to link to external libraries or pull in external files (as far as I've been able to tell yet)

Anyway, this seems fine and promising. I'll look into ibtool a bit more later. Feel free to drop by IRC, too!

copumpkin · 2017-04-13T02:02:56Z

Aha, ibtoold is what contains the meat of the logic

copumpkin · 2017-04-13T02:20:48Z

Aha, InterfaceBuilderKit.framework is yuuuge! This is going to be interesting 😄

copumpkin · 2017-04-13T02:21:09Z

Merging this since my random banter has no bearing on any of this stuff.

copumpkin · 2017-04-13T03:10:59Z

@matthewbauer have you looked at gorm at all, from GNUstep? It looks like it understands nibs and xibs, but it might not understand the cocoa stuff

matthewbauer · 2017-04-13T17:42:03Z

@copumpkin

I don't think gorm supports the .xib format. Apple just added it in Xcode 5 to support version control that didn't like changes to binary files. You're right that it's probably not too complicated and somebody with some RE skills like yourself or others could probably get it working but looking at xib2nib source, it's definitely not going to be too easy.

We actually have gorm in nixpkgs but it looks like it's broken right now on darwin at least.

I don't know if you've got any connections at Apple but maybe if we beg we can get them to open source ibtool? It definitely doesn't have a lot of applications for the average user but it certainly would make this whole thing easier. I suspect, however, that it would be impossible to open source ibtool without open sourcing the whole Cocoa framework and interface builder which is understandably closed source.

Also: do you know what's going on with Hydra? pinentry_mac isn't building for some reason but I can't get any logs on it. They're all in some non-text format. Maybe gzip?

https://lists.gnu.org/archive/html/gnustep-dev/2013-08/msg00078.html
http://wiki.gnustep.org/index.php/XIB

matthewbauer added 9 commits April 9, 2017 04:22

xcbuild: add app bundle specs

5eb75ce

install_name_tool: remove

a78af29

cctools provides install_name_tool

pinentry_mac: use xcbuild

38fa991

ibtool: add to toolchain

34422f4

- init package - add into xcbuild/toolchain.nix

xcbuild: try to fix sdk not found

87e6b2c

This is an attempt to get rid of the issues with sdk not found in xcbuild when building pinentry_mac.

pugixml: fixup darwin

f1fdc98

ibtool: use xib2nib src

bb2eb5b

ibtool: update to newer hash

c90058e

pinentry_mac: switch to pure version

457570f

Fixes NixOS#24734

matthewbauer added 4 commits April 12, 2017 03:21

xcbuild: remove unnecessary flags

f6860a6

ibtool: rename xib2nib

d697e5c

xib2nib: move nsplist, plistcpp to own folder

1781ec9

These libraries could be used by other packages so list them in all-packages.nix as well.

Revert "xcbuild: try to fix sdk not found"

3d1d805

This reverts commit 87e6b2c.

copumpkin approved these changes Apr 12, 2017

View reviewed changes

matthewbauer changed the title ~~pinentry_mac: use xcbuild~~ [wip] pinentry_mac: use xcbuild Apr 12, 2017

LnL7 added the 6.topic: darwin Running or building packages on Darwin label Apr 12, 2017

matthewbauer added 2 commits April 12, 2017 20:03

pinentry_mac: use precompiled .nib's

4672fe6

sadly, xib2nib hasn't been working like i though. I've just precompiled into our modified pinentry_mac. Eventually we can get this fixed but it's not as easy as first thought.

xib2nib: add meta

9e5fe77

also: - NSPlist - PlistCpp

matthewbauer changed the title ~~[wip] pinentry_mac: use xcbuild~~ pinentry_mac: use xcbuild Apr 13, 2017

copumpkin merged commit f21a694 into NixOS:master Apr 13, 2017

matthewbauer deleted the ibtool branch April 13, 2017 17:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

pinentry_mac: use xcbuild #24838

pinentry_mac: use xcbuild #24838

matthewbauer commented Apr 12, 2017 •

edited

mention-bot commented Apr 12, 2017

copumpkin commented Apr 12, 2017

matthewbauer commented Apr 12, 2017

copumpkin left a comment

matthewbauer commented Apr 12, 2017 •

edited

matthewbauer commented Apr 13, 2017 •

edited

copumpkin commented Apr 13, 2017 via email

matthewbauer commented Apr 13, 2017

copumpkin commented Apr 13, 2017

copumpkin commented Apr 13, 2017

matthewbauer commented Apr 13, 2017 •

edited

copumpkin commented Apr 13, 2017

matthewbauer commented Apr 13, 2017 •

edited

copumpkin commented Apr 13, 2017

copumpkin commented Apr 13, 2017

copumpkin commented Apr 13, 2017

copumpkin commented Apr 13, 2017

copumpkin commented Apr 13, 2017

matthewbauer commented Apr 13, 2017 •

edited

pinentry_mac: use xcbuild #24838

pinentry_mac: use xcbuild #24838

Conversation

matthewbauer commented Apr 12, 2017 • edited

Motivation for this change

Things done

mention-bot commented Apr 12, 2017

copumpkin commented Apr 12, 2017

matthewbauer commented Apr 12, 2017

copumpkin left a comment

Choose a reason for hiding this comment

matthewbauer commented Apr 12, 2017 • edited

matthewbauer commented Apr 13, 2017 • edited

copumpkin commented Apr 13, 2017 via email

matthewbauer commented Apr 13, 2017

copumpkin commented Apr 13, 2017

copumpkin commented Apr 13, 2017

matthewbauer commented Apr 13, 2017 • edited

copumpkin commented Apr 13, 2017

matthewbauer commented Apr 13, 2017 • edited

copumpkin commented Apr 13, 2017

copumpkin commented Apr 13, 2017

copumpkin commented Apr 13, 2017

copumpkin commented Apr 13, 2017

copumpkin commented Apr 13, 2017

matthewbauer commented Apr 13, 2017 • edited

matthewbauer commented Apr 12, 2017 •

edited

matthewbauer commented Apr 12, 2017 •

edited

matthewbauer commented Apr 13, 2017 •

edited

matthewbauer commented Apr 13, 2017 •

edited

matthewbauer commented Apr 13, 2017 •

edited

matthewbauer commented Apr 13, 2017 •

edited