Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mysql-haskell: dontCheck because check requires running server #24379

Merged
merged 1 commit into from Mar 27, 2017
Merged

mysql-haskell: dontCheck because check requires running server #24379

merged 1 commit into from Mar 27, 2017

Conversation

roberth
Copy link
Member

@roberth roberth commented Mar 27, 2017

Motivation for this change

mysql-haskell requires a running server. Running a server + checking would be nice but at least this makes the package available.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@roberth, thanks for your PR! By analyzing the history of the files in this pull request, we identified @peti, @pikajude and @mdorman to be potential reviewers.

@domenkozar domenkozar merged commit 8d2ca14 into NixOS:master Mar 27, 2017
@roberth roberth deleted the mysql-haskell-dontcheck branch June 27, 2017 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: haskell
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@roberth @mention-bot @domenkozar