bitcoin-unlimited: init at 1.0.1.3 #24378
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DmitryTsygankov, thanks for your PR! By analyzing the history of the files in this pull request, we identified @zimbatm, @zraexy and @AndersonTorres to be potential reviewers. |
|
Looks good to me. The first line of the commit should be "bitcoin-unlimited: init at 1.0.1.3", though. |
DmitryTsygankov
force-pushed
the
DmitryTsygankov/bitcoin-unlimited
branch
from
fc3583b
to
73956eb
Compare
Add the Bitcoin Unlimited client to the altcoins directory, so that all sides of the Bitcoin scaling debate are represented.
DmitryTsygankov
force-pushed
the
DmitryTsygankov/bitcoin-unlimited
branch
from
73956eb
to
02b0ea4
Compare
DmitryTsygankov
changed the title
|
@rycee fixed, thanks |
|
Sorry for the delay. Compiles and starts up OK for me. Rebased into master in 57a813f. Many thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the Bitcoin Unlimited client to the altcoins directory, so that all sides of the Bitcoin scaling debate are represented.
Motivation for this change
There is a scaling debate going on in Bitcoin. Bitcoin Core and Bitcoin Unlimited are the two most popular reference clients representing the two sides of the debate.
The currently less popular bitcoin-classic and bitcoin-xt are already in the package repository, it's time to add bitcoin-unlimited.
The bitcoin-unlimited package code is mostly a copy of bitcoin-classic, with appropriate modifications for the source repository, and version tags.
Was able to build and install the package on a NixOS machine, then run the GUI client & download the first few blocks of the blockchain.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)