Skip to content

keychain: add sigma as maintainer #24789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 10, 2017
Merged

keychain: add sigma as maintainer #24789

merged 1 commit into from
Apr 10, 2017
+2 −0

Conversation

sigma
Copy link
Member

@sigma sigma commented Apr 10, 2017

Motivation for this change

in #24771 @joachifm asked me if I wanted to take over this package

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@mention-bot
Copy link

@sigma, thanks for your PR! By analyzing the history of the files in this pull request, we identified @zimbatm, @zraexy and @edolstra to be potential reviewers.

@peterhoeg peterhoeg merged commit 3766b87 into NixOS:master Apr 10, 2017
@peterhoeg
Copy link
Member

Thanks for taking this on @sigma !

@sigma sigma deleted the pr/keychain-maintainer branch April 16, 2017 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sigma @mention-bot @peterhoeg