notmuch: fix homepage and notmuch-mutt license #24777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notmuch-mutt's license is GPLv3. might have been changed when it was upstreamed.
|
@asymmetric, thanks for your PR! By analyzing the history of the files in this pull request, we identified @garbas, @chaoflow and @burke to be potential reviewers. |
joachifm
reviewed
Apr 9, 2017
| @@ -99,6 +99,7 @@ stdenv.mkDerivation rec { | |||
|
|
|||
| meta = { | |||
| description = "Mail indexer"; | |||
| homepage = http://notmuchmmail.org/; | |||
There was a problem hiding this comment.
The http variant fails to resolve for me; https works, however.
There was a problem hiding this comment.
Fixed, thanks 👍
Should I squash?
joachifm
reviewed
Apr 9, 2017
| @@ -38,8 +38,8 @@ stdenv.mkDerivation rec { | |||
| meta = with lib; { | |||
| inherit version; | |||
| description = "Mutt support for notmuch"; | |||
| homepage = http://notmuchmua.org/; | |||
| license = with licenses; mit; | |||
| homepage = https://notmuchmail.org/; | |||
There was a problem hiding this comment.
Can you keep the field alignment as it was? Other than that, I think this is good to go.
joachifm
reviewed
Apr 9, 2017
| @@ -99,6 +99,7 @@ stdenv.mkDerivation rec { | |||
|
|
|||
| meta = { | |||
| description = "Mail indexer"; | |||
| homepage = https://notmuchmail.org/; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The homepage for notmuch was missing.
Additionally, the license for notmuch-mutt was incorrect. It might have been changed when it was upstreamed.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)