Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

polybar: 3.0.4 -> 3.0.5 #24782

Merged
merged 1 commit into from Apr 10, 2017
Merged

polybar: 3.0.4 -> 3.0.5 #24782

merged 1 commit into from Apr 10, 2017

Conversation

asymmetric
Copy link
Contributor

@asymmetric asymmetric commented Apr 9, 2017 •
edited

Motivation for this change
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 merged commit 92ab8b0 into NixOS:master Apr 10, 2017
@Mic92
Copy link
Member

Mic92 commented Apr 10, 2017

Thanks!

@asymmetric asymmetric deleted the polybar branch April 10, 2017 13:59
@JaniM
Copy link

JaniM commented Aug 15, 2017

@asymmetric Doesn't build with githubSupport enabled.

(pkgs.polybar.override { i3Support = true; githubSupport = true; })
[ 67%] Building CXX object bin/CMakeFiles/polybar.dir/utils/factory.cpp.o
[ 68%] Building CXX object bin/CMakeFiles/polybar.dir/utils/file.cpp.o
[ 69%] Building CXX object bin/CMakeFiles/polybar.dir/utils/http.cpp.o
/tmp/nix-build-polybar-3.0.5.drv-0/polybar-4e2e2a7/src/utils/http.cpp:2:28: fatal error: curl/curlbuild.h: No such file or directory
compilation terminated.
make[2]: *** [bin/CMakeFiles/polybar.dir/build.make:1311: bin/CMakeFiles/polybar.dir/utils/http.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:516: bin/CMakeFiles/polybar.dir/all] Error 2
make: *** [Makefile:130: all] Error 2
builder for ‘/nix/store/05kdm0xn4pldyghh25z7pkz4a1lx28ff-polybar-3.0.5.drv’ failed with exit code 2

Ftr,

(pkgs.polybar.override { i3Support = true; githubSupport = false; })

builds fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@asymmetric @Mic92 @JaniM