Skip to content

Added libpciaccess to steam-rt for a few games. #24792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Added libpciaccess to steam-rt for a few games. #24792

wants to merge 1 commit into from

Conversation

pstn
Copy link
Contributor

@pstn pstn commented Apr 10, 2017

Motivation for this change

Some Eugen systems games need libpciaccess and since it doesn't overwrite anything it should be harmless for anything that doesn't need it.

//cc @abbradar

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@mention-bot
Copy link

@pstn, thanks for your PR! By analyzing the history of the files in this pull request, we identified @abbradar, @hrdinka and @the-kenny to be potential reviewers.

Copy link
Member

@abbradar abbradar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename commit -- you don't add libpciaccess to steam-runtime but to steam-chrootenv. With our guidelines this becomes: steam: move libpciaccess as non-runtime dependencies.

@pstn pstn closed this Apr 10, 2017
@pstn pstn deleted the srt-libpciaccess branch April 10, 2017 16:39
@pstn pstn restored the srt-libpciaccess branch April 10, 2017 16:39
@lukateras lukateras added the 6.topic: steam Steam game store/launcher (store.steampowered.com) label Dec 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: steam Steam game store/launcher (store.steampowered.com)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants