tig: 2.2 -> 2.2.1 #24770
tig: 2.2 -> 2.2.1 #24770
Conversation
Also move to different project URLs, as requested in https://github.com/jonas/tig/releases/tag/tig-2.2.1
| url = "http://jonas.nitro.dk/tig/releases/${name}.tar.gz"; | ||
| sha256 = "0k3m894vfkgkj7xbr0j6ph91351dl6id5f0hk2ksjp5lmg9i6llg"; | ||
| url = "https://github.com/jonas/tig/releases/download/${name}/${name}.tar.gz"; | ||
| sha256 = "0wgsqdly3jd9c7b0ibb5vwsv4js19c5hi0698nf1fnfyjq40hj0b"; | ||
| }; | ||
|
|
||
| buildInputs = [ ncurses asciidoc xmlto docbook_xsl readline git makeWrapper ] |
There was a problem hiding this comment.
makeWrapper belongs in nativeBuildInputs
|
|
||
| src = fetchurl { | ||
| url = "http://jonas.nitro.dk/tig/releases/${name}.tar.gz"; |
There was a problem hiding this comment.
Have you tried fetchFromGitHub, as it is now the preferred method when possible. When you do it, rev is most likely gonna be:
rev = "v${version}"; sometimes it is rev = version; according how the upstream lists their version
|
@ndowens that was a little bit more involved than I thought (turns out the .tar.gz was a pre-configured version of the sources), but I think it should be ok now. |
sigma
force-pushed
the
pr/tig
branch
2 times, most recently
from
192054e
to
229670d
Compare
|
hmm, not sure what's going on with the OSX build (which works in my own setup) |
sigma
force-pushed
the
pr/tig
branch
4 times, most recently
from
2c63965
to
f6f7504
Compare
|
ok, I'm finally able to reproduce, by uninstalling the |
|
and what was wrong was that tig's Makefile kinda goes out of its way to make it's as impure as possible :) |
|
Instead of adding automake/autoconf and manually running ./autogen.sh, you can probably add |
|
I tried autoreconfHook but it didn't work |
Rework the dependencies to allow use of fetchFromGitHub.
|
@peterhoeg thanks, that seems to do the trick. @ndowens am I missing something? |
|
Thanks! |
Motivation for this change
Catch up with upstream.
Also move to different project URLs, as requested in
https://github.com/jonas/tig/releases/tag/tig-2.2.1
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)