Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodejs-7_x: 7.7.3 -> 7.8.0 #24779

Closed
wants to merge 1 commit into from
Closed

nodejs-7_x: 7.7.3 -> 7.8.0 #24779

wants to merge 1 commit into from

Conversation

cko
Copy link
Member

@cko cko commented Apr 9, 2017

Motivation for this change
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@cko
Copy link
Member Author

cko commented Apr 10, 2017

Build faile due to some Travis limitations with log length:

The log length has exceeded the limit of 4 MB (this usually means that the test suite is raising the same exception over and over).

The job has been terminated

@NeQuissimus
Copy link
Member

@cko Happens to a lot of builds, no worries :)

@lo1tuma
Copy link
Member

lo1tuma commented Apr 13, 2017

FWIW: in the meantime nodejs 7.9.0 has been released.

@lo1tuma lo1tuma mentioned this pull request Apr 18, 2017
Merged
7 tasks
@cko cko closed this Apr 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cko @NeQuissimus @lo1tuma