django_1_7: remove #24780
Merged
django_1_7: remove #24780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FRidh
approved these changes
Apr 9, 2017
lsix
reviewed
Apr 10, 2017
pkgs/top-level/python-packages.nix
Outdated
| @@ -10597,7 +10572,7 @@ in { | |||
| sha256 = "0wxvpmjdzk0aajk33y4himn3wqjx7k0aqlka9j8ay3yfav78bdq0"; | |||
| }; | |||
|
|
|||
| propagatedBuildInputs = with self; [ django_1_7 ]; | |||
| propagatedBuildInputs = with self; [ django_1_8 ]; | |||
There was a problem hiding this comment.
According to http://django-classy-tags.readthedocs.io/en/latest/changes.html an update of django_classy_tags could be used to bump django's version higher.
There was a problem hiding this comment.
we really should not depend on explicit versions. Packages that use a version of django or pytest should use just the main django or pytest attribute and not a specific attribute.
There was a problem hiding this comment.
The reason being we don't want risking multiple versions of a package in the same closure.
|
updated the PR so that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Django 1.7 is no longer supported by upstream (see: https://www.djangoproject.com/download/)
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)