Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mutt: actually make imap optional #24776

Merged
merged 1 commit into from Apr 9, 2017
Merged

Conversation

asymmetric
Copy link
Contributor

Motivation for this change

Previously, IMAP support was enabled even if the user had set imapSupport = false.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@asymmetric, thanks for your PR! By analyzing the history of the files in this pull request, we identified @rnhmjoj, @kosmikus and @urkud to be potential reviewers.

@joachifm joachifm merged commit da4fd5e into NixOS:master Apr 9, 2017
@joachifm
Copy link
Contributor

joachifm commented Apr 9, 2017

Thank you

@asymmetric asymmetric deleted the mutt-imap branch April 9, 2017 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants