Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keychain: 2.8.0 -> 2.8.3 #24771

Merged
merged 1 commit into from Apr 9, 2017
Merged

keychain: 2.8.0 -> 2.8.3 #24771

merged 1 commit into from Apr 9, 2017

Conversation

sigma
Copy link
Contributor

@sigma sigma commented Apr 9, 2017

Motivation for this change
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@sigma, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edwtjo, @rickynils and @badi to be potential reviewers.

@joachifm
Copy link
Contributor

joachifm commented Apr 9, 2017

I notice the package lacks a listed maintainer; would you care to add yourself as the maintainer?

@aristidb aristidb merged commit faa5d22 into NixOS:master Apr 9, 2017
@sigma sigma mentioned this pull request Apr 10, 2017
7 tasks
@sigma sigma deleted the pr/keychain branch April 16, 2017 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants