Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GTK3 by default in Firefox and Thunderbird #24787

Merged
merged 2 commits into from Apr 10, 2017
Merged

Conversation

abbradar
Copy link
Member

@abbradar abbradar commented Apr 9, 2017

Motivation for this change

#18559. I remember that there were problems at least with Firefox before; what were they?

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@vcunat
Copy link
Member

vcunat commented Apr 10, 2017

I don't remember anymore, but I don't think they matter, as upstream is supposed to be building with gtk3 by default for quite some time already.

@edolstra edolstra merged commit 0e0e7c1 into NixOS:master Apr 10, 2017
@vcunat
Copy link
Member

vcunat commented Apr 14, 2017

I found notes that I used to get unthemed gtk3 in FF, which made it hard to use, but that seems not to happen anymore.

@abbradar
Copy link
Member Author

Should be fixed by wrapGAppsHook maybe (BTW recently I needed to install gnome3.gnome_themes_standard to get Adwaita on XFCE back; it was there before. Don't think it's a bug though).

@vcunat
Copy link
Member

vcunat commented Apr 24, 2017

Now I'm sometimes getting disappearing text temporarily, e.g. in thunderbird messages "disappearing" one by one when I pass the mouse over the list. I'm not sure what causes it though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants