darwin: cleanup obsolete sdks #24252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@periklis, thanks for your PR! By analyzing the history of the files in this pull request, we identified @copumpkin, @gridaphobe and @spwhitt to be potential reviewers. |
|
If nothing is using these, then a thousand 👍 |
LnL7
reviewed
Mar 23, 2017
| @@ -11263,7 +11262,6 @@ with pkgs; | |||
|
|
|||
| xcode = callPackage ../os-specific/darwin/xcode {}; | |||
|
|
|||
| osx_sdk = callPackage ../os-specific/darwin/osx-sdk {}; | |||
There was a problem hiding this comment.
This is used by smlnj, maybe it can be replaced by the apple_sdk?
There was a problem hiding this comment.
right i missed to add this to the change-set
periklis
force-pushed
the
topic_darwin_cleanup
branch
from
34658e2
to
6414533
Compare
LnL7
approved these changes
Mar 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Since the upgrade to MacOS_sdk-10.10 in pure darwin, these duplicate sdks from 2015 are obsolete. Remaining sdk:
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)