Skip to content

Commit

Permalink
Revert "sddm: propagate qtbase input"
Browse files Browse the repository at this point in the history
This reverts commit 40db638.

Despite testing this in QEMU on my own machine, it breaks SDDM for everyone
else.
  • Loading branch information
ttuegel committed Mar 23, 2017
1 parent 3ff736b commit 056db1c
Showing 1 changed file with 3 additions and 21 deletions.
24 changes: 3 additions & 21 deletions pkgs/applications/display-managers/sddm/default.nix
@@ -1,4 +1,4 @@
{ stdenv, lib, makeQtWrapper, fetchFromGitHub, fetchpatch
{ stdenv, makeQtWrapper, fetchFromGitHub, fetchpatch
, cmake, extra-cmake-modules, pkgconfig, libxcb, libpthreadstubs, lndir
, libXdmcp, libXau, qtbase, qtdeclarative, qttools, pam, systemd
, themes
Expand Down Expand Up @@ -28,13 +28,10 @@ let
nativeBuildInputs = [ cmake extra-cmake-modules pkgconfig qttools ];

buildInputs = [
libxcb libpthreadstubs libXdmcp libXau pam systemd
qtbase qtdeclarative
libxcb libpthreadstubs libXdmcp libXau qtbase pam systemd
];

propagatedUserEnvPkgs = builtins.map lib.getBin [
qtbase qtdeclarative
];
propagatedBuildInputs = [ qtdeclarative ];

cmakeFlags = [
"-DCONFIG_FILE=/etc/sddm.conf"
Expand Down Expand Up @@ -83,21 +80,6 @@ stdenv.mkDerivation {
installPhase = ''
runHook preInstall
propagated=
for i in $unwrapped $themes; do
findInputs $i propagated propagated-user-env-packages
if [ -z "$crossConfig" ]; then
findInputs $i propagated propagated-native-build-inputs
else
findInputs $i propagated propagated-build-inputs
fi
done
for pkg in $propagated; do
addToSearchPath RUNTIME_XDG_DATA_DIRS "$pkg/share"
addToSearchPath RUNTIME_XDG_CONFIG_DIRS "$pkg/etc/xdg"
done
makeQtWrapper "$unwrapped/bin/sddm" "$out/bin/sddm"
mkdir -p "$out/share/sddm"
Expand Down

3 comments on commit 056db1c

@abbradar
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to generally follow my failure from #24133 (comment) -- if Qt parts are installed into system closure it breaks things.

@ttuegel
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That didn't install anything into the system environment. In fact, reverting it partially unwrapped SDDM, which means now it requires dependencies from the system environment. I believe this also breaks the Plasma theme, but I can't test that automatically.

@abbradar
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I was confused by propagatedUserEnvPkgs but I see now that it's not its conventional usage.

Please sign in to comment.