Skip to content

Commit 056db1c

Browse files
committedMar 23, 2017
Revert "sddm: propagate qtbase input"
This reverts commit 40db638. Despite testing this in QEMU on my own machine, it breaks SDDM for everyone else.
1 parent 3ff736b commit 056db1c

File tree

1 file changed

+3
-21
lines changed

1 file changed

+3
-21
lines changed
 

‎pkgs/applications/display-managers/sddm/default.nix

+3-21
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
{ stdenv, lib, makeQtWrapper, fetchFromGitHub, fetchpatch
1+
{ stdenv, makeQtWrapper, fetchFromGitHub, fetchpatch
22
, cmake, extra-cmake-modules, pkgconfig, libxcb, libpthreadstubs, lndir
33
, libXdmcp, libXau, qtbase, qtdeclarative, qttools, pam, systemd
44
, themes
@@ -28,13 +28,10 @@ let
2828
nativeBuildInputs = [ cmake extra-cmake-modules pkgconfig qttools ];
2929

3030
buildInputs = [
31-
libxcb libpthreadstubs libXdmcp libXau pam systemd
32-
qtbase qtdeclarative
31+
libxcb libpthreadstubs libXdmcp libXau qtbase pam systemd
3332
];
3433

35-
propagatedUserEnvPkgs = builtins.map lib.getBin [
36-
qtbase qtdeclarative
37-
];
34+
propagatedBuildInputs = [ qtdeclarative ];
3835

3936
cmakeFlags = [
4037
"-DCONFIG_FILE=/etc/sddm.conf"
@@ -83,21 +80,6 @@ stdenv.mkDerivation {
8380
installPhase = ''
8481
runHook preInstall
8582
86-
propagated=
87-
for i in $unwrapped $themes; do
88-
findInputs $i propagated propagated-user-env-packages
89-
if [ -z "$crossConfig" ]; then
90-
findInputs $i propagated propagated-native-build-inputs
91-
else
92-
findInputs $i propagated propagated-build-inputs
93-
fi
94-
done
95-
96-
for pkg in $propagated; do
97-
addToSearchPath RUNTIME_XDG_DATA_DIRS "$pkg/share"
98-
addToSearchPath RUNTIME_XDG_CONFIG_DIRS "$pkg/etc/xdg"
99-
done
100-
10183
makeQtWrapper "$unwrapped/bin/sddm" "$out/bin/sddm"
10284
10385
mkdir -p "$out/share/sddm"

3 commit comments

Comments
 (3)

abbradar commented on Mar 24, 2017

@abbradar
Member

This seems to generally follow my failure from #24133 (comment) -- if Qt parts are installed into system closure it breaks things.

ttuegel commented on Mar 24, 2017

@ttuegel
MemberAuthor

That didn't install anything into the system environment. In fact, reverting it partially unwrapped SDDM, which means now it requires dependencies from the system environment. I believe this also breaks the Plasma theme, but I can't test that automatically.

abbradar commented on Mar 24, 2017

@abbradar
Member

Oh, I was confused by propagatedUserEnvPkgs but I see now that it's not its conventional usage.

Please sign in to comment.