Is the property still since?

I'm working on this, I've gone through most of the changelog and still I have a few to solve.

I'll be uploading a PR soon with the part I get done by then.

@Serabe We basically just need the mapping from deprecation ID to version. We are going to have deprecation flags that take a semver version. This semver version will get turned into a bool based on what the consuming app says it supports.

If you just need the mapping, this is the list:

• container-lookup-factory not found in code
• ember-application.app-initializer-initialize-arguments 2.1.0
• ember-application.app-instance-container 2.1
• ember-application.app-instance-registry 2.1
• ember-application.injected-container 2.3.0
• ember-application.registry-resolver-as-function 2.3.0
• ember-application.validate-type 2.0.0
• ember-debug.deprecate-id-missing 2.1
• ember-debug.deprecate-options-missing 2.1
• ember-debug.deprecate-until-missing 2.1
• ember-debug.warn-id-missing 2.1
• ember-debug.warn-options-missing 2.1
• ember-htmlbars.ember-handlebars-safestring 2.8.0 (included before but reverted).
• ember-htmlbars.make-bound-helper 2.0
• ember-metal.binding 2.7
• ember-metal.ember-backburner 2.7.0
• ember-metal.ember-k 2.12.0
• ember-metal.immediate-observer 2.0
• ember-metal.observer-argument-order 2.0
• ember-metal.required 2.0
• ember-routing-views.controller-wrapped-param 2.0
• ember-routing.router-resource 2.0
• ember-routing.top-level-render-helper 2.11
• ember-runtime.action-handler-_actions 2.0
• ember-runtime.controller-proxy 2.0
• ember-runtime.enumerable-contains 2.7
• ember-runtime.freezable-init 2.0
• ember-runtime.frozen-copy 2.0
• ember-runtime.will-merge-mixin 2.0.
• ember-string-utils.fmt 2.0
• ember-template-compiler.deprecate-render 2.11
• ember-template-compiler.deprecate-render-model 2.6
• ember-template-compiler.transform-input-on-to-onEvent.dynamic-value 2.1
• ember-template-compiler.transform-input-on-to-onEvent.no-action 2.1
• ember-template-compiler.transform-input-on-to-onEvent.normalized-on 2.1
• ember-template-compiler.transform-old-binding-syntax 2.1
• ember-testing.test-waiters 2.7
• ember-views.component.defaultLayout 2.1
• ember-views.did-init-attrs 2.6
• ember-views.lifecycle-hook-arguments 2.12
• ember-views.render-double-modify 2.0
• ember-views.render-to-element 2.11

If you don't need the actual since option, shall I close #15064 ?

From the work (https://gist.github.com/andyhot/0c574101afc3ff25f95469453447930f) i had done for #14811, here's my (partial) findings:

• ember-application.registry-resolver-as-function 2.3.0
• container-lookupFactory 2.12.0
• ember-application.injected-container 2.3.0
• ember-metal.ember-k 2.12.0
• ember-metal.ember-backburner 2.7.0
• ember-metal.ember-create 1.13.3
• ember-metal.ember.keys 1.13.3
• ember-application.app-instance-container 2.1.0
• ember-application.app-initializer-initialize-arguments 2.1.0
• ember-application.validate-type 1.13.0
• ember-views.component.defaultLayout 2.7.0
• ember-routing-views.controller-wrapped-param 2.2.0
• ember-htmlbars.make-bound-helper 1.13.6
• ember-htmlbars.ember-handlebars-safestring 2.8.0
• ember-routing.router-resource 2.0.0
• ember-routing.top-level-render-helper 2.11.0

The differences I see with @Serabe 's findings:

• I had tracked ember-metal.ember-create and ember-metal.ember.keys though those do not appear in this issue. This might be because they were declared with deprecateFunc, so may have been missed by @chadhietala
• I had tracked container-lookupFactory and also included ember-application.app-instance-container, ember-routing.router-resource, ember-routing.top-level-render-helper in more details (though it's basically the same versions, i.e. 2.11.0 instead of 2.11)
• I have different versions for ember-application.validate-type, ember-views.component.defaultLayout, ember-routing-views.controller-wrapped-param and ember-htmlbars.make-bound-helper so someone should take another look at those

fyi, all of the versions i had found were from tracking down the tagged commits hence the more detail (though i can just be plain wrong in same cases where code was moved to different files)

@andyhot and @Serabe awesome! @Serabe I think we should keep your PR open still, I'm not sure if @rwjblue wants to do the since field in the deprecation. I don't know if it's needed with the thing I wrote.

So I think I need verification on these @rwjblue and if we should just go cleanup all the 1.13.0 flags. There is also some untils that have expired.

• 2.3.0 views.component.defaultLayout
• 2.3.0 ember-application.validate-type was an assertion first
• 2.2.0 ember-routing-views.controller-wrapped-param
• 2.3.0 ember-htmlbars.make-bound-helper

yep, all of those can can be cleaned up

Can this be closed?

@andyhot @chadhietala @locks @rwjblue closing for now, perhaps reopen or create a new issue to continue this effort if there is anything remaining.