Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

virtualbox: fix pulseaudio device access: #24259 #24268

Merged
merged 1 commit into from Mar 27, 2017
Merged

virtualbox: fix pulseaudio device access: #24259 #24268

merged 1 commit into from Mar 27, 2017

Conversation

deepfire
Copy link
Contributor

@deepfire deepfire commented Mar 24, 2017 •
edited

Motivation for this change

Fix #24259

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@deepfire, thanks for your PR! By analyzing the history of the files in this pull request, we identified @aszlig, @edolstra and @vcunat to be potential reviewers.

@deepfire
Copy link
Contributor Author

The failure is no space left on device:


kmk_builtin_append: failed to fclose '/run/user/1000/nix-build-virtualbox-5.1.18.drv-2/VirtualBox-5.1.18/out/linux.amd64/release/obj/VBoxOGLhostcrstate/state_tracker/state_multisample.o.dep'!: No space left on device
kmk: *** [/run/user/1000/nix-build-virtualbox-5.1.18.drv-2/VirtualBox-5.1.18/out/linux.amd64/release/obj/VBoxOGLhostcrstate/state_tracker/state_multisample.o] Error 1
kmk: *** Deleting file `/run/user/1000/nix-build-virtualbox-5.1.18.drv-2/VirtualBox-5.1.18/out/linux.amd64/release/obj/VBoxOGLhostcrstate/state_tracker/state_multisample.o'
kmk: *** Waiting for unfinished jobs....
{standard input}: Assembler messages:
{standard input}: Fatal error: can't write 121 bytes to section .rodata.str1.8 of /run/user/1000/nix-build-virtualbox-5.1.18.drv-1/VirtualBox-5.1.18/out/linux.amd64/release/obj/VBoxOGLhostcrstate/state_tracker/state_lists.o because: 'No space left on device

@deepfire
Copy link
Contributor Author

The build succeeds locally, on my machine, and indeed I'm using the resultant VirtualBox.

However, on Travis this build blows the 2G disk space limit: https://travis-ci.org/NixOS/nixpkgs/jobs/215361318#L879

878  /nix/store/ya481hkpjrnbwjrz8rrcn6yzd4ihc1bl-virtualbox-modules-5.1.18-3.10.105.drv
879  these paths will be fetched (676.97 MiB download, 1569.67 MiB unpacked):

...then, https://travis-ci.org/NixOS/nixpkgs/jobs/215361318#L2283:

2283  unpacking source archive /nix/store/0llwyj0qia7xj2k9qhw9n9dh6bbwjiid-linux-4.9.18.tar.xz
2284  source root is linux-4.9.18
2285  tar: linux-4.9.18/drivers/gpu/drm/amd/include/asic_reg/gca/gfx_8_1_sh_mask.h: Wrote only 7680 of 10240 bytes
2286  tar: linux-4.10.6/include/net/regulatory.h: Wrote only 1536 of 7801 bytes
2287  tar: linux-4.10.6/include/net/request_sock.h: Cannot write: No space left on device

I have no idea how much the disk limit ought to be raised to fix this.

One question is -- can this disk space limit be raised on a per-PR basis, or not? Raising this globally would be problematic, since @grahamc rightfully pointed out on IRC that Travis isn't in business to allow huge builds to happen.

@deepfire
Copy link
Contributor Author

/cc @domenkozar @joachifm @globin

@abbradar
Copy link
Member

Tested locally. Thanks for your work!

@abbradar abbradar merged commit 0c3138e into NixOS:master Mar 27, 2017
@deepfire
Copy link
Contributor Author

@abbradar, thanks!

@grahamc
Copy link
Member

grahamc commented Apr 2, 2017 via email

@deepfire deepfire deleted the virtualbox-fix-pulseaudio branch April 3, 2017 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@deepfire @mention-bot @abbradar @grahamc