Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spark: activate R backend #24358

Merged
merged 1 commit into from Mar 28, 2017
Merged

spark: activate R backend #24358

merged 1 commit into from Mar 28, 2017

Conversation

cko
Copy link
Member

@cko cko commented Mar 26, 2017

Motivation for this change

Spark can use R for data processing. So far this didn't work as the required variables weren't set.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@cko, thanks for your PR! By analyzing the history of the files in this pull request, we identified @thoughtpolice, @offlinehacker and @samuelrivas to be potential reviewers.

@NeQuissimus
Copy link
Member

I have not checked but I would imagine this makes the Spark closure quite a bit larger, does it not?
Maybe the R backend should be optional?

@cko
Copy link
Member Author

cko commented Mar 28, 2017

made it optional

@NeQuissimus NeQuissimus merged commit 91cd747 into NixOS:master Mar 28, 2017
@NeQuissimus
Copy link
Member

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants